Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(surveys): cancel listener should be on all questions #854

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix(surveys): cancel listener should be on all questions #854

merged 1 commit into from
Oct 24, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 24, 2023

Changes

Cancel listeners were only being applied to the first form cancel btn available.

Checklist

@liyiy liyiy added the bump patch Bump patch version when this PR gets merged label Oct 24, 2023
@github-actions
Copy link

Size Change: -3 B (0%)

Total Size: 728 kB

Filename Size Change
dist/surveys.js 39.7 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 178 kB
dist/array.js 119 kB
dist/es.js 119 kB
dist/module.js 119 kB
dist/recorder-v2.js 95.1 kB
dist/recorder.js 58.4 kB

compressed-size-action

@liyiy liyiy merged commit 2774323 into master Oct 24, 2023
14 checks passed
@liyiy liyiy deleted the fix-multiple-question-submit branch October 24, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liyiy